Project

General

Profile

Actions

Bug #134

closed

suricata content+depth+offset pb (FalseNegative)

Added by rmkml rmkml over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
High
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Hi,
I have downloaded latest suricata git version (v0.8.2 release have same pb), look my simply signature/rule:
alert tcp any any -> any 515 (msg:"detect IFS"; flow:to_server,established; content:"${IFS}"; depth:50; offset:0; classtype:attempted-dos; sid:900091; rev:1; )
Joigned pcap file (old lpd exploit) demonstrate the pb.
I have removed offset keyword on my signature/rule and alert firing!:
If anyone have a idea please?
Regards
Rmkml


Files

Actions #1

Updated by Victor Julien over 14 years ago

  • Due date set to 05/01/2010
  • Assignee set to Pablo Rincon
  • Priority changed from Normal to High
  • Target version set to 0.9.0
  • Estimated time set to 3.00 h
Actions #2

Updated by Gurvinder Singh over 14 years ago

The bug was caused by incorrect updation of depth length when offset is 0. Attached patch fix the bug. Again thanks Rmkml for pointing out :-)

Actions #3

Updated by Victor Julien over 14 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

I've applied the patch. Did a small modification of it. It now only updates cd->depth if depth != 0 and smaller than content_len + offset.

Actions

Also available in: Atom PDF