Bug #3113: python-yaml dependency is actually ptyhon3-yaml dependency - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #3113

closed

python-yaml dependency is actually ptyhon3-yaml dependency

Added by Peter Manev over 5 years ago. Updated about 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jason Ish

Target version:

5.0.0

Affected Versions:

Effort:

Difficulty:

Label:

Description

While installing Suricata (with suricata-update) from source on a clean Debian/Ubuntu system without having the pkg "python-yaml" present on the OS is triggering the following warning-

checking whether TPACKET_V3 is declared... yes
checking whether SOF_TIMESTAMPING_RAW_HARDWARE is declared... yes
checking for ./suricata-update/setup.py... yes

    Warning: suricata-update will not be installed as the
        depedency python-yaml is not installed.

    Debian/Ubuntu: apt install python-yaml
    Fedora: dnf install python-yaml
    CentOS/RHEL: yum install python-yaml

But suricata-update is installed only if the package "python3-yaml" is present on the system.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Andreas Herz over 5 years ago

Assignee set to OISF Dev
Target version set to TBD

I guess it might get harder in the future to cover all releases as some distris also change package names. But nevertheless we could change that to python3-yaml in that case.

Actions

Copy link

Updated by Jason Ish over 5 years ago

Package suggestions might get tricky, the Python 2 vs 3 also adds to the complexity here.

If the system has Python 3 installed, it will be used. So you need the Python 3 yaml module. If the system does not have Python 3, Python 2 will be used, so you will need the Python 2 yaml module.

Actions

Copy link

Updated by Victor Julien over 5 years ago

I think for the git master / 5.0 we can suggest the python3 based packages only.

Actions

Copy link

Updated by Victor Julien over 5 years ago

Status changed from New to Assigned
Target version changed from TBD to 5.0.0

Actions

Copy link

Updated by Andreas Herz over 5 years ago

Assignee changed from OISF Dev to Andreas Herz

Actions

Copy link

Updated by Andreas Herz over 5 years ago

We could use python3-yaml on recent fedora as well although we could also go for python3-pyyaml which the first is an alias to, same for CentOS 8.

I would propose:

    Debian/Ubuntu: apt install python3-yaml
    Fedora: dnf install python3-pyyaml
    CentOS/RHEL: yum install python3-pyyaml

Actions

Copy link

Updated by Jason Ish about 5 years ago

Can we close this? Git master now handles this a little differently. For example, if the Python yaml module is missing, this is now the message:

    Warning: suricata-update will not be installed as the
        Python yaml module is not installed..

    Install the yaml module for Python 2 to enable
    suricata-update.

With the following in the ./configure summary:

  Python support:                          yes
  Python path:                             /bin/python2.7
  Python distutils                         yes
  Python yaml                              no
  Install suricatactl:                     yes
  Install suricatasc:                      yes
  Install suricata-update:                 no, requires pyyaml

The idea here to keep from trying to be correct on every distro, which is getting harder, yet still give enough info to know whats wrong.

Perhaps a Wiki page for distribution specific installation notes.

Commit:
https://github.com/OISF/suricata/commit/109cf36866ee8743e94f44857f182ad76a4cc5f6

Actions

Copy link