Project

General

Profile

Actions

Bug #3432

closed

python: ensure proper shabang on python scripts

Added by Fabrice Fontaine almost 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
low
Difficulty:
low
Label:

Description

When installing python scripts, distutils would use the python used to
run setup.py as shebang for the scripts it installs.

However, when cross-compiling, this is most often not correct.

Instead, using '/usr/bin/env python' is guaranteed to find the proper
python in the PATH, so we need to instruct setup.py to use that as the
executable.

Actions #1

Updated by Shivani Bhardwaj over 1 year ago

  • Status changed from New to Assigned
  • Assignee set to Shivani Bhardwaj
  • Target version set to 7.0.0
  • Label deleted (Needs backport)

We no longer use distutils but env python is anyway better so I have proposed that in the main python scripts: https://github.com/OISF/suricata/pull/9079

Actions #2

Updated by Shivani Bhardwaj over 1 year ago

  • Status changed from Assigned to Closed

Jason made me see that since the scripts are no longer (if they were at some point before) run directly and the callers already have this portable shebang, we probably don't need this anymore. So, closing this issue. Feel free to open a new one if your issues persist.
Please note that the shebang changed as a part of https://github.com/OISF/suricata/commit/9a1d6af8582be4b817e9f0ffb9d5f591dfc31fb9

Thank you for taking interest in our project and helping make it better!

Actions #3

Updated by Shivani Bhardwaj over 1 year ago

  • Target version changed from 7.0.0 to 7.0.0-beta1
Actions

Also available in: Atom PDF