Project

General

Profile

Actions

Feature #3635

closed

datasets: add 'dataset-remove' unix command

Added by Victor Julien over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:
Needs backport to 5.0

Description

Only 'dataset-add' is implemented currently.


Related issues 1 (0 open1 closed)

Copied to Suricata - Feature #3673: datasets: add 'dataset-remove' unix commandClosedJeff LucovskyActions
Actions #1

Updated by Victor Julien over 4 years ago

  • Status changed from Assigned to In Review
  • Assignee changed from OISF Dev to Victor Julien
Actions #2

Updated by Victor Julien over 4 years ago

  • Status changed from In Review to Closed
  • Label Needs backport to 5.0 added
Actions #3

Updated by Victor Julien over 4 years ago

Since datasets are experimental, we can backport this feature. Relevant commits:

datasets: improve 'dataset-add' error checking
b80ab56

thash: add 'remove' support
51726e0

datasets: fix ref cnt handling
381bc2d

datasets: fix return values for 'add's
ff55a44

datasets: silence noisy 'dataset-add' log
03dc5d1

datasets: add 'remove' support
af06883

datasets: add 'dataset-remove' unix command
7a62697

datasets: remove useless variables
1d8d031

Actions #4

Updated by Jeff Lucovsky over 4 years ago

  • Copied to Feature #3673: datasets: add 'dataset-remove' unix command added
Actions

Also available in: Atom PDF