Actions
Bug #3730
closed1.0.x: Broken --http-header option
Affected Versions:
Effort:
low
Difficulty:
low
Label:
Description
Adding a header as described in the docs [[https://suricata-update.readthedocs.io/en/1.1.2/add-source.html#cmdoption-http-header]] does not work.
Steps to reproduce:
# suricata-update --version
suricata-update version 1.1.2
# suricata-update add-source test http://localhost:8080/rules/ --http-header "Header: Value"
13/5/2020 -- 10:42:06 - <Info> -- Using data-directory /var/lib/suricata.
13/5/2020 -- 10:42:06 - <Info> -- Found Suricata version 5.0.3 at /usr/bin/suricata.
# nc -l 8080 &
[1] 7026
# suricata-update
13/5/2020 -- 10:42:43 - <Info> -- Using data-directory /var/lib/suricata.
13/5/2020 -- 10:42:43 - <Info> -- Found Suricata version 5.0.3 at /usr/bin/suricata.
13/5/2020 -- 10:42:43 - <Info> -- Fetching http://localhost:8080/rules/.
GET /rules/ HTTP/1.1
Accept-Encoding: identity
Host: localhost:8080
User-Agent: Suricata-Update/1.1.2 (OS: Linux; CPU: x86_64; Python: 3.8.2; Suricata: 5.0.3)
Connection: close
Notice no "Header: Value" in what netcat sees
Updated by Jason Ish over 4 years ago
- Copied from Bug #3696: Broken --http-header option added
Updated by Shivani Bhardwaj over 4 years ago
- Status changed from New to Rejected
Seems like this was introduced by https://github.com/OISF/suricata-update/commit/f36c71bb9549791ed7d721221407d5cbd13c5169#diff-b117dc9956be2a723a248660048c4a4bR1000
This feature was not a part of 1.0.x. Closing.
Actions