Optimization #4475: Rust: Make default_port in parser registration an Option - Suricata - Open Information Security Foundation

Actions

Optimization #4475

closed

Rust: Make default_port in parser registration an Option

Added by Shivani Bhardwaj over 3 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Shivani Bhardwaj

Target version:

Effort:

Difficulty:

Label:

Related issues 1 (0 open — 1 closed)

Actions

#1

Updated by Shivani Bhardwaj over 3 years ago

Related to Optimization #3315: app-layer: unify registration logic added

Actions

#2

Updated by Shivani Bhardwaj over 3 years ago

Status changed from Assigned to In Review

Seems like using Option for `*const i8` is not FFI safe and Rust warns about it.
Using a null string in place of default port does seem to do the work though. Changed it in DCERPC only for now where there is not a fixed port of communication.
PR for review: https://github.com/OISF/suricata/pull/6234

Actions

#3

Updated by Shivani Bhardwaj over 3 years ago

Status changed from In Review to Closed

Closed by PR: https://github.com/OISF/suricata/pull/6350

Actions

Also available in: Atom PDF