Project

General

Profile

Actions
Copy link

Security #4486

closed

Security #4485: heap-buffer-overflow WRITE in InspectionBufferSetup with use of InspectionBufferGetMulti

Infinite loops in when using InspectionBufferMultipleForList

Added by Jeff Lucovsky over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeff Lucovsky
Target version:
5.0.7
Affected Versions:
5.0.6
Label:
CVE:
Git IDs:

fdc93130aaf9f4b97ad4ffa305f20d7b0b8be589

Severity:
MODERATE
Disclosure Date:

Description

From https://github.com/OISF/suricata/pull/5622#discussion_r626686822

POC is in #4476 once the buffer overflow gets fixed

Root cause is integer loss of precision casting local_id to uint16_t when there can more than 65536 buffers in a transaction

This may be not the case for dns.query as the maximum PDU length is 65536
But this is definitely the case for MQTT (subscribe topics) where Suricata default maximum PDU is 1Mbyte

Related issues 1 (0 open — 1 closed)

Copied from Suricata - Bug #4477: Infinite loops in when using InspectionBufferMultipleForListClosedPhilippe AntoineActions
Actions
Copy link
 #1

Updated by Jeff Lucovsky over 3 years ago

  • Copied from Bug #4477: Infinite loops in when using InspectionBufferMultipleForList added
Actions
Copy link
 #2

Updated by Philippe Antoine over 3 years ago

  • Assignee changed from Philippe Antoine to Jeff Lucovsky
  • Target version changed from 7.0.0-beta1 to 5.0.6
Actions
Copy link
 #3

Updated by Jeff Lucovsky over 3 years ago

  • Target version changed from 5.0.6 to 5.0.7
Actions
Copy link
 #4

Updated by Jeff Lucovsky over 3 years ago

  • Status changed from New to In Progress

Cherry-pick(s):
- 31312a918acba597042bdc76701373bc7957b403

Actions
Copy link
 #5

Updated by Jeff Lucovsky over 3 years ago

  • Status changed from In Progress to In Review
Actions
Copy link
 #6

Updated by Victor Julien over 3 years ago

  • Tracker changed from Bug to Security
  • Severity set to MODERATE
Actions
Copy link
 #7

Updated by Victor Julien over 3 years ago

  • Status changed from In Review to Closed
  • Affected Versions 5.0.6 added
  • Affected Versions deleted (6.0.2)
Actions
Copy link
 #8

Updated by Victor Julien over 3 years ago

  • Git IDs updated (diff)
Actions
Copy link
 #9

Updated by Victor Julien about 3 years ago

  • Private changed from Yes to No
Actions
Copy link

Also available in: Atom PDF