Bug #4712: lua: Use lua_pushinteger for pushing integer types as integers instead of floats - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #4712

closed

lua: Use lua_pushinteger for pushing integer types as integers instead of floats

Added by Shivani Bhardwaj about 3 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Shivani Bhardwaj

Target version:

6.0.4

Affected Versions:

Effort:

low

Difficulty:

Label:

Description

Prior to Lua 5.3, Lua only had one number type, float. Now that Lua 5.1 has integer types it makes sense to push integer values, specifically those around flow and packet tuples as integers. Luajit 5.1 and Liblua 5.0 has lua_pushinteger so compatibility should not be an issue.

Suricata-Verify test cases for SCPacketTuple() and SCFlowTuple() should also be created to show that they pass before and after this change without modification.

Related issues 1 (0 open — 1 closed)