Project

General

Profile

Actions

Bug #4921

closed

detect/app-layer-protocol: unexpected results when one direction state "failed"

Added by Victor Julien almost 3 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

When flow has alproto: http, but alproto_ts: failed, app-layer-protocol:http; or app-layer-protocol:!http; does not consider the "final" protocol, but instead only the alproto_ts.

This behavior isn't necessarily wrong, but there also needs to be a way to only consider the final protocol in this matching. Otherwise there is no reliable way to do something like

alert tcp any any -> any 80 (msg:"non-HTTP traffic over HTTP standard port"; flow:to_server; app-layer-protocol:!http; sid:1;)

Test case in https://github.com/OISF/suricata-verify/pull/615

I'm not entirely sure how to address this. Maybe we need to allow for an addition keyword parameter, e.g. something like:

app-layer-protocol:http,toserver; -> check alproto_ts
app-layer-protocol:http,final; -> check alproto
app-layer-protocol:http,both; -> check alproto_ts and alproto_tc

Actions #2

Updated by Philippe Antoine over 1 year ago

  • Assignee set to OISF Dev
  • Target version set to 8.0.0-beta1
Actions #3

Updated by Philippe Antoine 9 months ago

  • Assignee changed from OISF Dev to Philippe Antoine
Actions #4

Updated by Philippe Antoine 9 months ago

  • Status changed from New to In Review
Actions #5

Updated by Philippe Antoine 6 months ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF