Project

General

Profile

Actions

Bug #5821

closed

smtp-eve s-v test #4 does not pass on master-6.0.x

Added by Shivani Bhardwaj almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
Affected Versions:
Effort:
Difficulty:
Label:

Description

With the fix in the version checks of suricata-verify (ref: https://github.com/OISF/suricata-verify/pull/1098), this test started to fail.

Difference from expected behavior: Different file size

Needs analysis why the failure happens.


Related issues 1 (0 open1 closed)

Related to Suricata - Bug #5725: smtp: quoted-printable encoding skips empty lines in filesClosedPhilippe AntoineActions
Actions #1

Updated by Shivani Bhardwaj almost 2 years ago

  • Description updated (diff)
Actions #2

Updated by Victor Julien almost 2 years ago

  • Priority changed from Normal to High
Actions #3

Updated by Shivani Bhardwaj almost 2 years ago

  • Related to Bug #5725: smtp: quoted-printable encoding skips empty lines in files added
Actions #4

Updated by Shivani Bhardwaj almost 2 years ago

  • Status changed from Assigned to In Review
Actions #5

Updated by Philippe Antoine almost 2 years ago

@Shivani Bhardwaj was this fixed by S-V commit 579814085904075b95865d33bd376cb0426c137c ?

Actions #6

Updated by Philippe Antoine almost 2 years ago

I do not think we want to backport #5725 as it may be considered a breaking change

If so, the S-V check should only include the new file size for Suricata version 6

What about test smtp-file-data-02 ?

Actions #7

Updated by Shivani Bhardwaj almost 2 years ago

Philippe Antoine wrote in #note-5:

@Shivani Bhardwaj was this fixed by S-V commit 579814085904075b95865d33bd376cb0426c137c ?

This issue in smtp tests was found with this commit.

Actions #8

Updated by Shivani Bhardwaj almost 2 years ago

Philippe Antoine wrote in #note-6:

I do not think we want to backport #5725 as it may be considered a breaking change

It has already been backported: https://redmine.openinfosecfoundation.org/issues/5735

If so, the S-V check should only include the new file size for Suricata version 6

What about test smtp-file-data-02 ?

Seems like it works at it is set to require min-version: 6

Actions #9

Updated by Victor Julien almost 2 years ago

  • Status changed from In Review to Closed
  • Priority changed from High to Normal
  • Target version deleted (6.0.11)
Actions

Also available in: Atom PDF