Project

General

Profile

Actions

Bug #6787

closed

decode/pppoe: Suspicious pointer scaling

Added by Philippe Antoine 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

pppoedt = pppoedt + (4 + tag_length);. looks like it can overflow on 32-bits system


Subtasks 2 (0 open2 closed)

Bug #6809: decode/pppoe: Suspicious pointer scaling (6.0.x backport)RejectedPhilippe AntoineActions
Bug #6810: decode/pppoe: Suspicious pointer scaling (7.0.x backport)ClosedPhilippe AntoineActions
Actions #2

Updated by Philippe Antoine 10 months ago

  • Status changed from New to In Review
Actions #3

Updated by Philippe Antoine 10 months ago

  • Tracker changed from Security to Bug
  • Private changed from Yes to No
  • Severity deleted (MODERATE)

Actually, this is a bug, but not a security issue.

There is no unsigned overflow because we upgrade a u16 read on the network to u32

But there is still the bug that we do pointer arithmetic with something different than the u8 pkt buffer...

Actions #4

Updated by Philippe Antoine 10 months ago

  • Target version changed from TBD to 8.0.0-beta1
Actions #5

Updated by OISF Ticketbot 10 months ago

  • Subtask #6809 added
Actions #6

Updated by OISF Ticketbot 10 months ago

  • Label deleted (Needs backport to 6.0)
Actions #7

Updated by OISF Ticketbot 10 months ago

  • Subtask #6810 added
Actions #8

Updated by OISF Ticketbot 10 months ago

  • Label deleted (Needs backport to 7.0)
Actions #9

Updated by Victor Julien 10 months ago

  • Subject changed from decode/ppoe: Suspicious pointer scaling to decode/pppoe: Suspicious pointer scaling

@Philippe Antoine can you fix the title of the backport tickets?

Actions #10

Updated by Philippe Antoine 10 months ago

Victor Julien wrote in #note-9:

catenacyber can you fix the title of the backport tickets?

Had to look twice at the diff to see it :-p

Actions #11

Updated by Victor Julien 10 months ago

Off by one I guess ;)

Actions #12

Updated by Philippe Antoine 10 months ago

  • Status changed from In Review to Resolved
Actions #13

Updated by Philippe Antoine 10 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF