Project

General

Profile

Actions
Copy link

Optimization #6855

open

src: var code cleanups

Added by Victor Julien 10 months ago. Updated 2 months ago.

Status:
In Review
Priority:
Normal
Assignee:
Jeff Lucovsky
Target version:
8.0.0-beta1
Effort:
Difficulty:
Label:

Description

GenericVar and related types use a field "type" which is 8 bits, but it is used to hold the sigmatch type, which is 16 bits. It's not currently causing issues, but needs to be cleaned up.

Actions
Copy link
 #1

Updated by Philippe Antoine 10 months ago

How come we did not have a compiler warning for this ?..

Actions
Copy link
 #2

Updated by Philippe Antoine 10 months ago

Philippe Antoine wrote in #note-1:

How come we did not have a compiler warning for this ?..

Looks like GenericVar type is never set by itself, but setting it in a FlowVar or such and then casting to this common struct...

Actions
Copy link
 #3

Updated by Jeff Lucovsky 2 months ago

  • Status changed from New to In Review
  • Assignee changed from OISF Dev to Jeff Lucovsky
  • Target version changed from TBD to 8.0.0-beta1
Actions
Copy link

Also available in: Atom PDF