Project

General

Profile

Actions

Security #7209

closed

thash: random factor not used; possible abusive hash collisions

Added by Jason Ish 3 months ago. Updated 16 days ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Label:
Git IDs:

26da953f6dad3793d29f27ce7ab6628a2db8f471

Severity:
CRITICAL
Disclosure Date:

Description

util-thash.c initializes a random factor, however, this is not used. I suspect the intention was to introduce some randomness.


Subtasks 1 (0 open1 closed)

Security #7258: thash: random factor not used; possible abusive hash collisions (7.0.x backport)ClosedPhilippe AntoineActions

Related issues 2 (1 open1 closed)

Related to Suricata - Optimization #3322: Use standard CRC32 for hash-like functionsNewCommunity TicketActions
Related to Suricata - Security #7289: http: missing hashtable random seed leads to potential DoSClosedPhilippe AntoineActions
Actions #1

Updated by Philippe Antoine 3 months ago

cf usage of StringHashDjb2 in ContainerUrlRangeHash, network traffic induced

Actions #3

Updated by Victor Julien about 1 month ago

  • Label Needs backport to 7.0 added
Actions #4

Updated by Victor Julien about 1 month ago

  • Target version changed from TBD to 8.0.0-beta1
Actions #5

Updated by OISF Ticketbot about 1 month ago

  • Subtask #7258 added
Actions #6

Updated by OISF Ticketbot about 1 month ago

  • Label deleted (Needs backport to 7.0)
Actions #7

Updated by Philippe Antoine about 1 month ago

git grep 5381 shows a lot of redefinition of StringHashDjb2

Actions #8

Updated by Philippe Antoine about 1 month ago

  • Status changed from New to In Review

Gitlab POC

Actions #9

Updated by Philippe Antoine about 1 month ago

Actions #10

Updated by Victor Julien about 1 month ago

  • Tracker changed from Bug to Security
  • Assignee changed from OISF Dev to Philippe Antoine
  • Severity set to CRITICAL
Actions #11

Updated by Juliana Fajardini Reichow about 1 month ago

  • Related to Security #7289: http: missing hashtable random seed leads to potential DoS added
Actions #14

Updated by Philippe Antoine about 1 month ago

  • Git IDs updated (diff)
Actions #15

Updated by Victor Julien 16 days ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF