Project

General

Profile

Actions
Copy link

Optimization #879

closed

update configure.ac with autoupdate

Added by Victor Julien over 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Andreas Herz
Target version:
5.0rc1
Effort:
Difficulty:
Label:

Description

The autoupdate tool modernizes configure.ac and cleans up formatting. Might be interesting to try it.

Actions
Copy link
 #1

Updated by Eric Leblond over 11 years ago

  • % Done changed from 0 to 90
Actions
Copy link
 #2

Updated by Victor Julien about 11 years ago

  • Target version changed from 2.0beta2 to TBD
  • % Done changed from 90 to 10

This turned out to have side effects on older platforms, so postponing for now.

Actions
Copy link
 #3

Updated by Victor Julien about 11 years ago

  • Tracker changed from Feature to Optimization
Actions
Copy link
 #4

Updated by Andreas Herz over 8 years ago

  • Assignee changed from Eric Leblond to Andreas Herz

Worth looking at it again when we now try to make configure.ac consistent.

Actions
Copy link
 #5

Updated by Andreas Herz about 7 years ago

Since some time has passed I would like to give it a new try:

https://github.com/inliniac/suricata/pull/2904

It would be nice if some of you could test that on your distributions as well. I tested it on ArchLinux and Ubuntu 16.04 LTS.

Actions
Copy link
 #6

Updated by Andreas Herz about 7 years ago

It would also help for some other improvements within our configure script like #1835 and would like to have it merged to use it for the future work on those configure tasks.

Actions
Copy link
 #7

Updated by Andreas Herz almost 7 years ago

With all the other PR I would also suggest we add some sort of check within the buildbot so we won't get back old (not modern) configure.ac

Actions
Copy link
 #8

Updated by Andreas Herz over 5 years ago

Eric and I need to discuss this with regards to the possible checks within the buildbot

Actions
Copy link
 #9

Updated by Andreas Herz over 5 years ago

Should we close this, since we converted it or should we wait until we have some sort of check at the QA that we don't reintroduce old behaviour?

Actions
Copy link
 #10

Updated by Victor Julien over 5 years ago

  • Status changed from Assigned to Closed
  • Target version changed from TBD to 5.0rc1

https://github.com/OISF/suricata/pull/3955

I don't think the QA part of this is critical. Errors will be caught by existing QA. We can review changes, as well as the whole thing regularly.

Actions
Copy link

Also available in: Atom PDF