Optimization #5545
Updated by Juliana Fajardini Reichow over 2 years ago
*** This is an onboarding task for the Outreachy project for increasing code coverage for our rule keywords *** We have many keywords that have the 'prefilter' feature, for which the prefilter keyword itself isn't yet tested. This task encompasses In the simpler cases, for which cases of this task, one will have to add the 'prefilter' keyword to an already existing suricata-verify test that covers the rule keyword (this would be the case for 'filemagic' for instance). instance. Some other cases would also require creating the SV tests themselves. Those cases will be covered by a different ticket. Examples of tests for 'filemagic': - filestore-filecontainer-http - filestore-filecontainer-smb How do we know that the prefilter for filemagic needs coverage? We check https://app.codecov.io/gh/OISF/suricata/blob/master/src/detect-filemagic.c (An example of a case that does not fit in this task is the fragbits keyword. While it supports 'prefilter', we must first add coverage to the 'fragbits' keyword itself: https://app.codecov.io/gh/OISF/suricata/blob/master/src/detect-fragbits.c)