Project

General

Profile

Actions
Copy link

Bug #1064

closed

Lack of Thread Deinitialization For Decoder Modules

Added by Amin Latifi almost 11 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Victor Julien
Target version:
2.0.1rc1
Affected Versions:
Effort:
Difficulty:
Label:

Description

I checked Suricata code and I found out that decoder thread modules don't set ThreadDeinit member of their TmModule in tmm_modules table.

It somehow doesn't seem normal. Since, decode threads have at least one member in their DecodeThreadVars which maybe should be deinitialized. Actually, I realized DecodeThreadVars contains AlpProtoDetectThreadCtx member and the AlpProtoDetectThreadCtx variables maybe should be deinitialized by using AlpProtoFinalize2Thread function; similar what happens in StreamTcpThreadDeinit (StreamTcp thread deinitializing) procedure.

So, I don't know the implementation of decoders' deinitialization has been missed mistakenly? or not implementing of that doesn't make any problem?

Actions
Copy link

Also available in: Atom PDF