Suricata » Suricata-Update

At the moment, trying to enable a source that is already enabled will result in suricata-update failing with a return code of 1 and the error message:

2018-12-04 17:15:14,285 - <ERROR> - The source oisf/trafficid is already enabled.

This is problematic, for example, when using Ansible to set up and maintain an environment where configuration of various sources is necessary. The idea is to be able to repeatedly apply the role without running into an error (and without having to explicitly check whether a source is enabled or disabled). I would be happy submit a patch that tackles this, e.g. by making this a warning only and not returning a nonzero return code.