Actions
Bug #2867
closedFailure with missing rule params
Affected Versions:
Effort:
low
Difficulty:
low
Label:
Beginner, Outreachy
Description
If someone by mistake forgets a semicolon or changes a rule to not have a gid or sid, it leads to the following error:
Traceback (most recent call last):
File "/bin/suricata-update", line 33, in <module>
sys.exit(main.main())
File "/bin/../lib/python3.4/site-packages/suricata/update/main.py", line 1454, in main
sys.exit(_main())
File "/bin/../lib/python3.4/site-packages/suricata/update/main.py", line 1334, in _main
rulemap = build_rule_map(rules)
File "/bin/../lib/python3.4/site-packages/suricata/update/main.py", line 696, in build_rule_map
if rule.id not in rulemap:
File "/bin/../lib/python3.4/site-packages/suricata/update/rule.py", line 121, in id
return (int(self.gid), int(self.sid))
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'
Actions