Feature #3464: suricata-verify: Add unix-socket support - Suricata - Open Information Security Foundation

Custom queries

8.0.0 Stories
Good First Issues
OISF community

Actions

Copy link

Feature #3464

open

suricata-verify: Add unix-socket support

Added by Shivani Bhardwaj over 4 years ago. Updated over 3 years ago.

Status:

Assigned

Priority:

Low

Assignee:

Jason Ish

Target version:

Effort:

Difficulty:

Label:

Description

suricata-verify should be able to test unix-socket commands.

History
Notes
Property changes

Actions

Copy link

Updated by Victor Julien over 4 years ago

Priority changed from Normal to Low

I wonder if we should split this ticket in 2:

1. be able to run the standard tests in unix socket (so instead of running suricata -r ... set up unix socket and run through suricatasc)
2. add special support for adding tests that interact with unix socket to test issues like #3448

Actions

Copy link

Updated by Shivani Bhardwaj about 4 years ago

Assignee changed from Shivani Bhardwaj to Community Ticket

Actions

Copy link

Updated by Shivani Bhardwaj almost 4 years ago

Relevant conversation:

Victor Julien
In shell you would start suri to go into the background suricata .... & and then issue the commands, where you capture suri's PID so you can kill it after you're done.

But I think this isn't as nice as an error in the script can easily leave suri running.

Shivani Bhardwaj
I see. We could probably have a blanket try..except..finally block which makes sure that suri is killed (how barbaric!) even if there was an exception. Would it still miss any cases?

Victor Julien
That sounds sane to me. We'd first issue a shutdown over unix socket, and if suri is still running after that do a force kill and fail the test.

Actions

Copy link