Project

General

Profile

Actions
Copy link

Optimization #4607

closed

Optimization #4591: Fix Rust clippy lints

Fix warning about "match like matches macro"

Added by Juliana Fajardini Reichow about 3 years ago. Updated almost 2 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Target version:
-
Effort:
Difficulty:
Label:
Beginner, Good First Issue, Outreachy, Rust

Description

We are working on cleaning our Rust code from lint warnings.

For resolving this issue, please check the rust code and fix warnings related to "match expression looks like `matches!` macro".

For more details on this warning, check
https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

More information on the parent issue.

Actions
Copy link
 #2

Updated by Juliana Fajardini Reichow almost 2 years ago

  • Status changed from New to Rejected

This lint will sometimes result in less readable code, for us, so we have decided to allow this warning.

Our recommendation is that the match macro use is recommended where it makes sense.

Actions
Copy link
 #3

Updated by Juliana Fajardini Reichow almost 2 years ago

  • Assignee set to Jason Ish
Actions
Copy link
 #4

Updated by Victor Julien almost 2 years ago

  • Assignee deleted (Jason Ish)
Actions
Copy link

Also available in: Atom PDF