Project

General

Profile

Actions
Copy link

Bug #4899

closed

suricata-verify: exceptions caused by code errors can be silently ignored

Added by Jason Ish almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Jason Ish
Target version:
QA
Affected Versions:
Effort:
Difficulty:
Label:

Description

If you look the code change in this Suricata-Verify pull request, https://github.com/OISF/suricata-verify/pull/605/files, it looks like this should cause a runtime error as its calling a function that doesn't exist. However, in the exception handling this type of error is being silently absorbed.

The result is that tests that trigger this code path are not even displayed in the S-V output, and are not recorded as failures.

Ideally code errors like this should just have their exceptions raised to the top so the failure is spectacular.

Actions
Copy link

Also available in: Atom PDF