Project

General

Profile

Actions

Optimization #4908

closed

ftp: use AppLayerResult instead of buffering wherever possible

Added by Shivani Bhardwaj almost 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Use AppLayerResult https://github.com/OISF/suricata/blob/master/src/app-layer-parser.h#L84-L98 instead of buffering the data.
If the length of the required incomplete data is not known, return 1 from AppLayerResult::incomplete to indicate that at least one more byte is required by the parser if it's available.


Related issues 2 (1 open1 closed)

Related to Suricata - Optimization #4907: smtp: use AppLayerResult instead of buffering wherever possibleClosedShivani BhardwajActions
Blocks Suricata - Feature #4906: ftp: add stream app-layer frame support AssignedOISF DevActions
Actions

Also available in: Atom PDF