Bug #5012
closed
Remove duplicate definition of constants between C and Rust
Added by Philippe Antoine almost 3 years ago.
Updated over 1 year ago.
Description
Discussion comes from https://github.com/OISF/suricata/pull/6840
PGSQL_LOG_PASSWORDS is not exported by cbindgen
With the following patch
-pub const PGSQL_LOG_PASSWORDS: u32 = BIT_U32!(1);
+pub const PGSQL_LOG_PASSWORDS: u32 = 2;
it does get exported
FLOW_DIR_REVERSED is another example
CI should ensure this get no longer added
- Related to Bug #5007: pgsql: coverity warning added
- Priority changed from Normal to Low
- Priority changed from Low to Normal
- Target version changed from 7.0.0-beta1 to TBD
- Related to Optimization #4517: cbindgen export the constants from Rust to C, also for macro such as BIT_U8(1), and remove duplicate definitions between rust and C added
Looks like the best is to get rid of rust `BIT_U` macros
Or maybe have a dummy cbindgen-like which does the headers for BIT_U macros...
- Status changed from New to Closed
Also available in: Atom
PDF