Project

General

Profile

Actions
Copy link

Bug #5282

closed

6.0.x: ftp: don't let first incomplete segment be over maximum length

Added by Jeff Lucovsky over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jason Ish
Target version:
6.0.6
Affected Versions:
6.0.5
Effort:
Difficulty:
Label:

Description

The first non-terminated ftp command segment is buffered with no size limit. This results in a subsequent segment causing an integer to enter a negative state which is then asserted on with a DEBUG_VALIDATE_BUG_ON. Make sure the first segment is subject to limits of subsequent segments.

Then result is non-debug-validate-bug-on builds is that the first logged segment can be up to 65k, but their should be no security related issue here as the right thing is already done for negative values.

Related issues 1 (0 open — 1 closed)

Copied from Suricata - Bug #5281: ftp: don't let first incomplete segment be over maximum lengthClosedJason IshActions
Actions
Copy link
 #1

Updated by Jeff Lucovsky over 2 years ago

  • Copied from Bug #5281: ftp: don't let first incomplete segment be over maximum length added
Actions
Copy link
 #2

Updated by Jason Ish over 2 years ago

  • Assignee changed from Shivani Bhardwaj to Jason Ish
Actions
Copy link
 #3

Updated by Jason Ish over 2 years ago

  • Status changed from Assigned to In Review
Actions
Copy link
 #4

Updated by Jason Ish over 2 years ago

  • Subject changed from ftp: don't let first incomplete segment be over maximum length to 6.0.x: ftp: don't let first incomplete segment be over maximum length
  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF