Project

General

Profile

Actions

Bug #5457

closed

Counters are not initialized in all places.

Added by tug tugtug over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:
Needs backport to 6.0

Description

counter_alerts_overflow and counter_alerts_suppressed are only initialized in DetectEngineThreadCtxInit in detect-engine.c, but not in DetectEngineThreadCtxInitForReload.

i.e. once suricata rules are reload, these 2 counters would become invalid and writes to incorrect structure in StatsAddUI64. In fact, if one turns on debugging, the BUG_ON should trigger in StatsAddUI64.


Subtasks 1 (0 open1 closed)

Bug #5459: Counters are not initialized in all places. (6.0.x backport)ClosedJuliana Fajardini ReichowActions

Related issues 1 (0 open1 closed)

Copied to Suricata - Bug #5459: Counters are not initialized in all places. (6.0.x backport)ClosedJuliana Fajardini ReichowActions
Actions #1

Updated by Juliana Fajardini Reichow over 2 years ago

  • Assignee changed from OISF Dev to Juliana Fajardini Reichow
Actions #2

Updated by Juliana Fajardini Reichow over 2 years ago

  • Target version changed from TBD to 6.0.7
Actions #3

Updated by Juliana Fajardini Reichow over 2 years ago

  • Target version changed from 6.0.7 to 7.0.0-beta1
  • Affected Versions 5.0.9 added
  • Label Needs backport to 5.0, Needs backport to 6.0 added
Actions #4

Updated by Juliana Fajardini Reichow over 2 years ago

  • Copied to Bug #5459: Counters are not initialized in all places. (6.0.x backport) added
Actions #5

Updated by Juliana Fajardini Reichow over 2 years ago

  • Subtask #5459 added
Actions #6

Updated by Juliana Fajardini Reichow over 2 years ago

  • Affected Versions 5.0.10 added
  • Affected Versions deleted (5.0.9)
  • Label deleted (Needs backport to 5.0)
Actions #7

Updated by Juliana Fajardini Reichow over 2 years ago

  • Status changed from New to In Review
Actions

Also available in: Atom PDF