Optimization #5544
closedtls keywords: increase code coverage and update documentation (if need be)
Description
If we look at https://app.codecov.io/gh/OISF/suricata/blob/master/src/detect-tls.c
we will notice that some keywords, such as 'subject' (https://suricata.readthedocs.io/en/latest/rules/tls-keywords.html#tls-subject) and 'issuerdn' (https://suricata.readthedocs.io/en/latest/rules/tls-keywords.html#tls-issuerdn) are not covered by our tests.
This ticket's work includes:
- Identify other tls keywords that also need coverage
- Add suricata-verify tests with rules that make use of those
- Check if we need to update our userguide documentation on those rules, and improve it accordingly
Updated by Juliana Fajardini Reichow almost 2 years ago
- Target version changed from TBD to 8.0.0-beta1
Updated by Juliana Fajardini Reichow almost 2 years ago
- Private changed from Yes to No
Updated by Juliana Fajardini Reichow almost 2 years ago
- Assignee changed from Community Ticket to Haleema Khan
Updated by Haleema Khan almost 2 years ago
- Status changed from New to In Review
S-V PR for review https://github.com/OISF/suricata-verify/pull/1074
Updated by Haleema Khan almost 2 years ago
Userguide PR for review https://github.com/OISF/suricata/pull/8436
Updated by Juliana Fajardini Reichow over 1 year ago
Merged documentation PR: https://github.com/OISF/suricata/pull/8505
Waiting on the SV one to be merged, now.
Updated by Haleema Khan over 1 year ago
- Status changed from In Review to Closed
Updated by Victor Julien over 1 year ago
- Target version changed from 8.0.0-beta1 to 7.0.0-rc2