Project

General

Profile

Actions
Copy link

Task #6352

open

Task #6308: detect/analyzer: add more keyword details

detect/analyzer: add more details for the tcp window keyword

Added by Juliana Fajardini Reichow about 1 year ago. Updated 8 days ago.

Status:
In Review
Priority:
Normal
Assignee:
Nancy Enos
Target version:
8.0.0-beta1
Effort:
Difficulty:
Label:
Beginner, C, Outreachy

Description

Add more details to the tcp window keyword engine analysis output.

See what the TCP windows keyword has on https://docs.suricata.io/en/latest/rules/header-keywords.html#window

There are more general explanations in the parent task.

Related issues 2 (1 open — 1 closed)

Copied from Suricata - Task #6351: detect/analyzer: add more details for the xbits keywordNewCommunity TicketActions
Copied to Suricata - Task #6353: detect/analyzer: add more details for the tcp seq keywordClosedDaniel OlatunjiActions
Actions
Copy link
 #1

Updated by Juliana Fajardini Reichow about 1 year ago

  • Copied from Task #6351: detect/analyzer: add more details for the xbits keyword added
Actions
Copy link
 #2

Updated by Juliana Fajardini Reichow about 1 year ago

  • Copied to Task #6353: detect/analyzer: add more details for the tcp seq keyword added
Actions
Copy link
 #3

Updated by Victor Julien 5 months ago

  • Target version changed from 8.0.0-beta1 to TBD
Actions
Copy link
 #4

Updated by Nancy Enos 9 days ago

I would like to work on this ticket, should i just assign it to myself?

also am not sure how to represent the negation detail of tcp-window.

jb_set_bool(js, "negation", wd->negated);

thats what am thinking

Actions
Copy link
 #5

Updated by Juliana Fajardini Reichow 9 days ago

Nancy Enos wrote in #note-4:

I would like to work on this ticket, should i just assign it to myself?

Hi, yes, please feel free to assign it to yourself.

also am not sure how to represent the negation detail of tcp-window.

jb_set_bool(js, "negation", wd->negated);

thats what am thinking

Checking some suricata-verify tests that have keywords that allow for negation, I see that we usually use negated, so I would go with that:

jb_set_bool(js, "negated", wd->negated);
Actions
Copy link
 #6

Updated by Nancy Enos 9 days ago

  • Status changed from New to Assigned
  • Assignee changed from Community Ticket to Nancy Enos
Actions
Copy link
 #7

Updated by Juliana Fajardini Reichow 8 days ago

  • Status changed from Assigned to In Progress
Actions
Copy link
 #8

Updated by Juliana Fajardini Reichow 8 days ago

  • Status changed from In Progress to In Review
Actions
Copy link
 #9

Updated by Juliana Fajardini Reichow 8 days ago

  • Target version changed from TBD to 8.0.0-beta1
Actions
Copy link

Also available in: Atom PDF