Project

General

Profile

Actions
Copy link

Optimization #7297

closed

Remove duplicate function declarations

Added by Philippe Antoine 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Nancy Enos
Target version:
8.0.0-beta1
Effort:
Difficulty:
Label:
Beginner, C, Good First Issue, Outreachy

Description

As in https://github.com/OISF/suricata/pull/11856

cat src/*.h | sort | uniq -c | awk '$1 == 2' finds all duplicated lines

SCRunmodeGet in suricata.h is another duplicate to remove

Actions
Copy link
 #1

Updated by Nancy Enos 3 months ago

Hey, please add me as developer so i can claim this issue..i have set up suricata

Actions
Copy link
 #2

Updated by Victor Julien 3 months ago

Nancy Enos wrote in #note-1:

Hey, please add me as developer so i can claim this issue..i have set up suricata

Done

Actions
Copy link
 #3

Updated by Nancy Enos 2 months ago

  • Status changed from New to Assigned
  • Assignee changed from Community Ticket to Nancy Enos
Actions
Copy link
 #4

Updated by Juliana Fajardini Reichow 2 months ago

  • Status changed from Assigned to In Review
Actions
Copy link
 #6

Updated by Nancy Enos 2 months ago

  • Status changed from In Review to Closed
Actions
Copy link
 #7

Updated by Philippe Antoine 2 months ago

  • Status changed from Closed to In Progress

Cool, but it looks like there are still some remaining :
AppLayerDecoderEventsFreeEvents
PrefilterGenericMpmFrameRegister

What do you think about these ?

Actions
Copy link
 #8

Updated by Nancy Enos 2 months ago

hey i have checked them out and created a pull request https://github.com/OISF/suricata/pull/12044

Actions
Copy link
 #9

Updated by Juliana Fajardini Reichow about 2 months ago

  • Target version changed from TBD to 8.0.0-beta1
Actions
Copy link
 #10

Updated by Juliana Fajardini Reichow about 2 months ago

  • Status changed from In Progress to Closed

Follow up work merged with PR: https://github.com/OISF/suricata/pull/12088

Actions
Copy link

Also available in: Atom PDF