Optimization #7352
open
Remove disable-hashing command line option
Added by Philippe Antoine about 2 months ago.
Updated about 2 months ago.
Description
It comes from f723dc1309a793f6fbcf81d6507fe946b4caa04a :
The idea with a flag to disable hashing is to provide a way to
get the effect of building Suricata without libnss, which is
sometimes done for performance reasons.
We do not have nss anymore...
The only other occurrence of nss I find in the code is in util-file.h comment about includes and rust
- Status changed from New to In Review
- Target version changed from 8.0.0-beta1 to TBD
Also disable-hashing is incomplete : hassh, quic cyu, datasets and more use hashes and are not disabled by the option
- Assignee changed from Philippe Antoine to OISF Dev
Philippe Antoine wrote in #note-2:
Also disable-hashing is incomplete : hassh, quic cyu, datasets and more use hashes and are not disabled by the option
Ticket should probably be updated to make sure --disable-hashing is respected.
@Victor Julien Any thoughts on keeping this flag around and why?
Also available in: Atom
PDF