Feature #789
closedClean-up start and stop code
Description
As seen during the work on unix socket, the start and stop code of suricata has become messy and needs to be improved. In particular, suricata.c needs to be clean up.
Updated by Victor Julien over 11 years ago
I think one of the first things we should do is determine the runmode and determine how many threads of each type we are going to be using. For example, in oisf-devel we're talking about per-worker flow engines. This implies that at initialization of the flow engine(s), we need to know the runmode and number of threads. Unless we move the flow engine init to the threads init. Anyhow, something to consider.
Updated by Eric Leblond over 11 years ago
I've started to look into it. Regarding two separate aspects: unix socket running mode and the flow issue you mentioned, I think we should migrate a lot of init and cleaning code to the running mode code. This will allow to simplify the unix socket related code and have full flexibility regarding the Flow manager.
If no objection, I continue to look into this.
Updated by Eric Leblond over 11 years ago
The PR https://github.com/inliniac/suricata/pull/415 is implementing some factorization...
Updated by Eric Leblond over 11 years ago
I don't think, packet acquisition is not changed.
Updated by Victor Julien over 11 years ago
- Target version changed from 2.0beta1 to 2.0beta2
Updated by Eric Leblond almost 11 years ago
- Status changed from New to Closed
Closing it for now. Work has been merged.