Bug #106
closedInline functions should be moved to .h files were appropriate
Description
Steve Grubb from Redhat reported the following issue. We should move the inline functions to the .h files where appropriate or change the functions to no longer be inline.
"The other issue is that inline functions are still not right. Inline functions
are like macros with type checking. The whole function must be in the header
and not the .c file. If its in a .c file, then gcc can't possibly inline the
function since it cannot see the source code. Older versions of gcc faked this
by treating inlined functions as normal functions."
Files
Updated by Will Metcalf over 14 years ago
- Assignee changed from OISF Dev to Pablo Rincon
- Estimated time changed from 2.50 h to 4.50 h
Updating hours assigning to Pablo.
Updated by Pablo Rincon over 14 years ago
- File 0001-Inline-functions.patch 0001-Inline-functions.patch added
- File 0002-Moving-back-to-.c-files-the-functions-that-gcc-canno.patch 0002-Moving-back-to-.c-files-the-functions-that-gcc-canno.patch added
- % Done changed from 0 to 90
Moved inline functions to static inlines at the .h files. Some of them were not possible as gcc was reporting errors with -Winline param, those are fixed in the second patch as regular functions.
Updated by Will Metcalf over 14 years ago
- Estimated time changed from 4.50 h to 5.50 h
updating hours
Updated by Victor Julien over 14 years ago
- Target version changed from 0.8.2 to 0.9.0
Moving to 0.9.0.
Updated by Victor Julien over 14 years ago
- Status changed from New to Closed
- % Done changed from 90 to 100
Patches are applied, thanks Pablo.