Project

General

Profile

Actions
Copy link

Bug #106

closed

Inline functions should be moved to .h files were appropriate

Added by Will Metcalf almost 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Pablo Rincon
Target version:
0.9.0
Affected Versions:
Effort:
Difficulty:
Label:

Description

Steve Grubb from Redhat reported the following issue. We should move the inline functions to the .h files where appropriate or change the functions to no longer be inline.

"The other issue is that inline functions are still not right. Inline functions
are like macros with type checking. The whole function must be in the header
and not the .c file. If its in a .c file, then gcc can't possibly inline the
function since it cannot see the source code. Older versions of gcc faked this
by treating inlined functions as normal functions."

Files

Download all files
0001-Inline-functions.patch (353 KB) 0001-Inline-functions.patch Pablo Rincon, 03/15/2010 12:47 PM
0002-Moving-back-to-.c-files-the-functions-that-gcc-canno.patch (96.9 KB) 0002-Moving-back-to-.c-files-the-functions-that-gcc-canno.patch Pablo Rincon, 03/15/2010 12:47 PM
Actions
Copy link

Also available in: Atom PDF