Project

General

Profile

Actions
Copy link

Task #4182

closed

lua: Use lua_pushinteger for pushing integer types as integers instead of floats

Added by Jason Ish about 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Juliana Fajardini Reichow
Target version:
7.0.0-beta1
Effort:
low
Difficulty:
low
Label:
Needs backport to 6.0

Description

Prior to Lua 5.3, Lua only had one number type, float. Now that Lua 5.1 has integer types it makes sense to push integer values, specifically those around flow and packet tuples as integers. Luajit 5.1 and Liblua 5.0 has lua_pushinteger so compatibility should not be an issue.

Suricata-Verify test cases for SCPacketTuple() and SCFlowTuple() should also be created to show that they pass before and after this change without modification.

Related issues 2 (0 open — 2 closed)

Related to Suricata - Support #4088: SCPacketTuple() not return correct protocol typeClosedActions
Copied to Suricata - Bug #4712: lua: Use lua_pushinteger for pushing integer types as integers instead of floatsClosedShivani BhardwajActions
Actions
Copy link

Also available in: Atom PDF